User Tools
subsystem:gatekeepers
Differences
This shows you the differences between two versions of the page.
|
subsystem:gatekeepers [2018/05/23 16:34] jsmoeller created |
subsystem:gatekeepers [2018/05/23 20:05] jsmoeller |
||
|---|---|---|---|
| Line 10: | Line 10: | ||
| ===== The bylaws for gatekeepers ===== | ===== The bylaws for gatekeepers ===== | ||
| - | - Reviews should stay open at least 24h to allow other developers/maintainers/gatekeepers to comment. | + | - Reviews should stay open at least 24h to allow other developers/maintainers/gatekeepers to comment. Longer if you need a maintainer or developer to comment. |
| - The submitter of a patch should not vote +2 on his own patch (unless documented in commit message or comment in jira) | - The submitter of a patch should not vote +2 on his own patch (unless documented in commit message or comment in jira) | ||
| - | - The gatekeepers should add reviewers to the changesets where they think this is necessary (and not already done through the plugin) | + | - At least two maintainers or developers should +1 beside a gatekeeper whenever possible. Preferably a peer developer that is not directly involved in the particular issue. |
| - | - Apply common sense and think about *all* targets/framework/board - not just the current/special case. | + | - The gatekeepers should add reviewers to the changesets where they think this is necessary (and not already done through the gerrit reviewer plugin) |
| - | - ... | + | - Apply common sense and think about *all* targets/framework/boards - not just the current/special case. |
| + | - more to be added. | ||
| ===== Open issues, discussions ===== | ===== Open issues, discussions ===== | ||
subsystem/gatekeepers.txt · Last modified: 2018/05/23 20:05 by jsmoeller
Page Tools
