====== AGL Gatekeepers ====== The group of gatekeepers of AGL are responsible for merging code into the AGL codebase and thus deal with the day-to-day workflow in [[https://gerrit.automotivelinux.org|gerrit]] by voting and merging changes. They have the right to vote +2/-2 and also merge code. ===== Current gatekeepers ===== The current list of gatekeepers can be retrieved from gerrit: https://gerrit.automotivelinux.org/gerrit/#/admin/groups/15 ===== The bylaws for gatekeepers ===== - Reviews should stay open at least 24h to allow other developers/maintainers/gatekeepers to comment. Longer if you need a maintainer or developer to comment. - The submitter of a patch should not vote +2 on his own patch (unless documented in commit message or comment in jira) - At least two maintainers or developers should +1 beside a gatekeeper whenever possible. Preferably a peer developer that is not directly involved in the particular issue. - The gatekeepers should add reviewers to the changesets where they think this is necessary (and not already done through the gerrit reviewer plugin) - Apply common sense and think about *all* targets/framework/boards - not just the current/special case. - more to be added. ===== Open issues, discussions ===== Open issues and questions shall be raised at the developer call (tuesday).